Автор / Сообщение

New Horizons v14.0920 ENG v2.0 (Satshanti) Bug Reports

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Чт Dec 04, 2014 10:37 Заголовок сообщения:

Satshanti писал(а):

Now you should be able to deduct my age. Smile

I "carbon-dated" you when you mentioned your first Rush album Wink

Satshanti писал(а):

I wonder how that would work, also in combination with the use of my translation database. I guess they would have to be maintained separately in parallel then?

Yes, that was my idea. I'll upload each of your patches to the repository, so changes between versions can be quickly inspected. I'll also make "personal" changes (like a few Unit names) which you can then pick up (or not) for what I'll call the official English version. And I'll post my personal version in a separate thread.

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Чт Dec 04, 2014 11:09 Заголовок сообщения:

Here are the (non-text) differences in var between your version and mine:
http://eador.online.fr/var_diffs.txt

(You should download the file, and open it in an editor that doesn't speak UTF-8, to see the BOMs.)

Worth pointing out:
- 15 files have received a BOM (my goal is to produce 7-bit ASCII clean files)
- in names.var the first letter of class names was changed to lower case (not important, but was it on purpose?)
- I think this one is an actual BUG: in players.var

Код:

-ExitDialogs: (352, 353, 309, 107, 354,180, 181, 434, 285, 509, 553, 554, 606, 686)
+ExitDialogs: (352, 353, 309, 107, 354.180, 181, 434, 285, 509, 553, 554, 606, 686)

I think it should be

Код:

ExitDialogs: (352, 353, 309, 107, 354, 180, 181, 434, 285, 509, 553, 554, 606, 686)

(When I get around to finishing my parser, it should catch these kinds of bugs)

Regards.

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Чт Dec 04, 2014 11:32 Заголовок сообщения:

Wayne писал(а):

In the "dragonroot" random event dialog, when I select "plow the land", I don't see any further dialog text. Previously I would get a message about the province income increasing by X amount per turn. And I think the province income is not increasing.

Do you mean this event:

Код:

/1483 Тайная лощина
Window: 2;
Bitmap: 88;
Text: #While exploring the province of %s, the hero %s has found a secret hollow. Dragonroot, a rare herb with magical properties, grows here on the banks of a small rivulet. Gathering it can increase gem income. But if you plow up these fertile lands, taxes from the province will be significantly increased. Another option is to allow the settlers to build their houses here, life in such a picturesque place will have a wholesome effect on population mood. #
Answer1: Gather dragonroot.;
Answer2: Plow the land here.;
Answer3: Let people settle here.;
Answer4: Leave this wonderful hollow intact.;#####

Here are the relevant entries:

Код:

/688 Тайная лощина
Type: 0
Possibility: 0
Dialog: 1483
DlgParam1: 3
DlgParam2: 1
Attacker: 0
EncWin: 0
EncLose: 0
EncDraw: 0
Karma: 0

*Answers*:
Answer1: 0
Answer2: 689
Answer3: 690
Answer4: 691;

*Effects*:
Index: 30
Power: 1
Param1: 0
Param2: 0;

/689 Тайная лощина, распахать
Type: 0
Possibility: 0
Dialog: 0
DlgParam1: 0
DlgParam2: 0
Attacker: 0
EncWin: 0
EncLose: 0
EncDraw: 0
Karma: 0

*Answers*:
Answer1: 0;

*Effects*:
Index: 28
Power: 62
Param1: 0
Param2: 0;

/690 Тайная лощина, заселить
Type: 0
Possibility: 0
Dialog: 0
DlgParam1: 0
DlgParam2: 0
Attacker: 0
EncWin: 0
EncLose: 0
EncDraw: 0
Karma: 1

*Answers*:
Answer1: 0;

*Effects*:
Index: 28
Power: 63
Param1: 0
Param2: 0;

/691 Тайная лощина, оставить
Type: 0
Possibility: 0
Dialog: 0
DlgParam1: 0
DlgParam2: 0
Attacker: 0
EncWin: 0
EncLose: 0
EncDraw: 0
Karma: 4

*Answers*:
Answer1: 0;

*Effects*:
Index: 28
Power: 0
Param1: 0
Param2: 0;

Plow the land is Answer2, so entry 689.
*Effects*:
Index: 28
Power: 62
Param1: 0
Param2: 0;

Mods: what file does Index point into?

Regards.

Satshanti

-Мастер Убийца-
moderator

Свитков: 176
С нами с: 27.10.2014
Откуда: Scotland

Добавлено: Чт Dec 04, 2014 11:40 Заголовок сообщения:

Wayne писал(а):

Hmmm, this is not a text-based bug. Due to the nature of the automatic translation process, very few actual game-changing bugs should have sneaked into the English release, so it could very well already have been in the Russian release. Still, down this thread Boon mentions one error in the var-files, and it would be a coincidence if exactly that error would in fact lead to your noticed bug. Boon, would you be willing and able to look into that? I think you know more about how variables and files are linked within the game.

Wayne писал(а):

An old bug in the texts: in the casino, when you go to the exchanger, you are asked "What do you want to exchange?", but really the question should be "What do you want to receive?" That is, if you answer the question "gold", then you get asked how many gems you want to exchange into gold. Alternatively you could swap the answers "gold" and "gems" and leave the question as is.

Funny you should mention this, exactly like you, I also got confused at that spot, so I already fixed it with patch 2.06 yesterday. It now reads "What would you like to receive in the exchange?"

Satshanti

-Мастер Убийца-
moderator

Свитков: 176
С нами с: 27.10.2014
Откуда: Scotland

Добавлено: Чт Dec 04, 2014 11:50 Заголовок сообщения:

Hey Boon, you're already on top of it! Our posts had crossed...
Thanks for your other remarks. I'll have to do some "real" work today, but hopefully will have time to have a closer look at it tonight. I already got some other fixes lined up for v2.07 too. Smile

And I'd forgotten about mentioning Rush. Don't much like their newer stuff though, you know, from the last 30 years. Smile

They started losing my interest ever since Power Windows. I did love to see their Beyond the lighted stage documentary and the latest Snakes & Arrows concerts. Okay, off topic! Smile

Satshanti

-Мастер Убийца-
moderator

Свитков: 176
С нами с: 27.10.2014
Откуда: Scotland

Добавлено: Чт Dec 04, 2014 20:15 Заголовок сообщения:

Boon947 писал(а):

in names.var the first letter of class names was changed to lower case (not important, but was it on purpose?)

No, no idea how that happened, but as you say, not important...

Boon947 писал(а):

I think this one is an actual BUG: in players.var

Код:

-ExitDialogs: (352, 353, 309, 107, 354,180, 181, 434, 285, 509, 553, 554, 606, 686)
+ExitDialogs: (352, 353, 309, 107, 354.180, 181, 434, 285, 509, 553, 554, 606, 686)

I think it should be

Код:

ExitDialogs: (352, 353, 309, 107, 354, 180, 181, 434, 285, 509, 553, 554, 606, 686)

Yes, the must have error sneaked in due to the missing space in the original. I guess the translation program considered two numbers to be one number and changed the comma to a dot, and I must have missed that. Fixed now. Thanks!

Kettarienne

* Бессмертный *
moderator
New Horizons Team

Свитков: 1500
С нами с: 09.10.2012

Добавлено: Пт Dec 05, 2014 7:15 Заголовок сообщения:

Boon947 писал(а):

*Effects*:
Index: 28
Power: 62
Param1: 0
Param2: 0;

Mods: what file does Index point into?

28: Destroy current site. If Power>0 - replace with site Power.
In this case, it destroys site 61 (initial site, that calls the encounter on find, and adds 2 to the province gem income when not hidden) and creates site 62, which adds 5 to province gold income.
_________________
Phenomenal self as such is not an epistemically justified form of mental content.

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Пт Dec 05, 2014 14:21 Заголовок сообщения:

Kettarienne писал(а):

Boon947 писал(а):

*Effects*:
Index: 28
Power: 62
Param1: 0
Param2: 0;

Mods: what file does Index point into?

Ket,

I'm investigating Wayne's bug report:

Wayne писал(а):

The initial encounter is #688, which has 4 possible Answers
Answer1: 0
Answer2: 689
Answer3: 690
Answer4: 691;

which map to
Answer1: Gather dragonroot.;
Answer2: Plow the land here.;
Answer3: Let people settle here.;
Answer4: Leave this wonderful hollow intact.;#####

If the user picks Answer1, then the outcome should be gem income +2 (i.e. site.var #61 Name: Secret Hollow;)
but the Effect for Answer1 is AFAIU:

*Effects*:
Index: 30
Power: 1
Param1: 0
Param2: 0;

What's Index 30/Power 1? (Will take a close read at the GOG posting by Gremlion -- is that you? or Alexey?)

Regards.

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Пт Dec 05, 2014 14:52 Заголовок сообщения:

Boon947 писал(а):

If the user picks Answer1, then the outcome should be gem income +2 (from site.var #61 Name: Secret Hollow)
but the Effect for Answer1 is:

*Effects*:
Index: 30
Power: 1
Param1: 0
Param2: 0;

What's Index 30/Power 1?

http://www.gog.com/forum/eador_series/moddingindexes/post2
Effects
28 Destroy current site. If (Power > 0) then replace with site $Power
30 Set in DialogParam=3 current province name (Power must be 1)

Shouldn't the effect be this?

Index: 28
Power: 61
Param1: 0
Param2: 0;

To actually get the Secret Hollow site? (And the +2 gem bonus)

Ability:
Ability: 2
Param1: 0
Param2: 2;

2 gold income Param 1 crystal income Param 2 => so GEM +2

I'll check MotBW.

Regards.

Satshanti

-Мастер Убийца-
moderator

Свитков: 176
С нами с: 27.10.2014
Откуда: Scotland

Добавлено: Пт Dec 05, 2014 15:46 Заголовок сообщения:

I've found a strange bug I am not able to fix. It seems to be text-based, but I've looked at unit.var, where you would think something must be wrong, and I can't discover anything.

Have a look at this screenshot:

https://drive.google.com/file/d/0BwMWyw77HfkXUXc5aTNFTWdpanM/view?usp=sharing

When you actually enter combat and right click on the ballista or catapult, the same strange characters appear in the titles.

It seems the error must be in unit.var under /101 and /102 but as far as I can see, the name variables are fine. It's a mystery to me...

Has anyone got any idea?

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Пт Dec 05, 2014 15:48 Заголовок сообщения:

Boon947 писал(а):

I'll check MotBW.

Does anyone know how to unpack their .pak format?
I tried QuArK (Quake Army Knife) but it's an incompatible format.

Kettarienne

* Бессмертный *
moderator
New Horizons Team

Свитков: 1500
С нами с: 09.10.2012

Добавлено: Пт Dec 05, 2014 15:57 Заголовок сообщения:

Boon947 писал(а):

I'm investigating Wayne's bug report:

Which is false, what he describes was never a case. I got vanilla right here, and several old mod versions.

Boon947 писал(а):

If the user picks Answer1, then the outcome should be gem income +2 (i.e. site.var #61 Name: Secret Hollow;)
but the Effect for Answer1 is AFAIU:

*Effects*:
Index: 30
Power: 1
Param1: 0
Param2: 0;

What's Index 30/Power 1?

It is effect of the encounter (this one send the province name to the dialog: encounters, unlike events, do not do this automatically), they take place right when it fires, and answers just point to other encounters. In this case, the answer is, essentially, "do nothing", so it points to encounter 0 which returns nothing and ends dialog. +2 gem income is granted by the site 61 itself, which is already present (it's discovery is what calls the encounter), so nothing, indeed, needs to be done. There is no bug, everithing works as intended.

Satshanti писал(а):

Has anyone got any idea?

Don't know. But they are a tad long... Try shortening them names a bit?
_________________
Phenomenal self as such is not an epistemically justified form of mental content.

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Пт Dec 05, 2014 16:46 Заголовок сообщения:

Kettarienne писал(а):

Which is false, what he describes was never a case. I got vanilla right here, and several old mod versions.

I meant no disrespect. Is there a simple way to test things in-game, such as forcing an encounter?
Maybe by rigging the probabilities for the desired encounter?

Kettarienne писал(а):

Don't know. But they are a tad long... Try shortening them names a bit?

That's an excellent suggestion. Looks like a buffer overflow.
Checking other Name lengths...

Код:

$ grep ^Name unit.var | while read F V; do echo ${#V} $V; done | sort -rn | head -20
25 Catapult of the Ancients;
25 Ballista of the Ancients;
22 Lizardman-spellcaster;
21 Tree of the Departed;
21 Guardian of Darkness;
20 Warrior of Darkness;
20 Dwarven Firestarter;
19 Oracle of Elements;
19 Master Necromancer;
19 Master Constructor;
19 Lizardman-sentinel;
19 Lizardman-champion;
19 Elemental Mistress;
19 Dwarven Blacksmith;
18 Daokon's Guardian;
17 Warrior of Decay;
17 Veteran Spearman;
17 Paragon of Light;
17 Nocturnal Hunter;
17 Lord of Darkness;

And the Russian version

Код:

$ grep ^Name unit.var | while read F V; do echo ${#V} $V; done | sort -rn | head -20 | iconv -f cp1251
21 Танцующий-с-клинками;
20 Старший конструктор;
19 Повелитель Распада;
19 Мать-Хранительница;
19 Катапульта Древних;
19 Затронутый Смертью;
19 Говорящий-с-Духами;
19 Воплощение Воздуха;
19 Великий инквизитор;
18 Наездник на волке;
18 Костяной копейщик;
18 Воспрявший Светоч;
18 Болотная стрекоза;
17 Ящер-заклинатель;
17 Штурмовое орудие;
17 Хранитель памяти;
17 Охотник на ведьм;
17 Мастер-некромант;
17 Кровавый мотылёк;
17 Капитан латников;

Regards.

Satshanti

-Мастер Убийца-
moderator

Свитков: 176
С нами с: 27.10.2014
Откуда: Scotland

Добавлено: Пт Dec 05, 2014 16:57 Заголовок сообщения:

Boon947 писал(а):

Kettarienne писал(а):

Don't know. But they are a tad long... Try shortening them names a bit?

That's an excellent suggestion. Looks like a buffer overflow.
Checking other Name lengths...

I'll try it out. The next longest one I have already encountered and was rendered correctly was the lizardman-sentinel. I'll look into it...

Satshanti

-Мастер Убийца-
moderator

Свитков: 176
С нами с: 27.10.2014
Откуда: Scotland

Добавлено: Пт Dec 05, 2014 17:18 Заголовок сообщения:

Satshanti писал(а):

Boon947 писал(а):

Kettarienne писал(а):

Don't know. But they are a tad long... Try shortening them names a bit?

That's an excellent suggestion. Looks like a buffer overflow.
Checking other Name lengths...

I'll try it out. The next longest one I have already encountered and was rendered correctly was the lizardman-sentinel. I'll look into it...

Okay, the third one in your list, Boon, the lizardman-spellcaster, still works fine, but the first 2 I mentioned both seem to be too long by just a tiny bit. Now that I've changed them to "Ancients' Ballista" and "Ancients' Catapult" the error doesn't occur. Well done, guys, I would never have guessed that could be it. I don't even know what a buffer overflow it, although I can guess... Smile

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Пт Dec 05, 2014 17:30 Заголовок сообщения:

Satshanti писал(а):

Boon947 писал(а):

Kettarienne писал(а):

Don't know. But they are a tad long... Try shortening them names a bit?

That's an excellent suggestion. Looks like a buffer overflow.
Checking other Name lengths...

I'll try it out. The next longest one I have already encountered and was rendered correctly was the lizardman-sentinel. I'll look into it...

How did you test the Lizardman-spellcaster so quickly?

Satshanti

-Мастер Убийца-
moderator

Свитков: 176
С нами с: 27.10.2014
Откуда: Scotland

Добавлено: Пт Dec 05, 2014 17:31 Заголовок сообщения:

Boon947 писал(а):

Satshanti писал(а):

Boon947 писал(а):

Kettarienne писал(а):

Don't know. But they are a tad long... Try shortening them names a bit?

That's an excellent suggestion. Looks like a buffer overflow.
Checking other Name lengths...

I'll try it out. The next longest one I have already encountered and was rendered correctly was the lizardman-sentinel. I'll look into it...

How did you test the Lizardman-spellcaster so quickly?

just by temporarily giving the ballista that name! Smile

Kettarienne

* Бессмертный *
moderator
New Horizons Team

Свитков: 1500
С нами с: 09.10.2012

Добавлено: Пт Dec 05, 2014 20:25 Заголовок сообщения:

Boon947 писал(а):

I meant no disrespect. Is there a simple way to test things in-game, such as forcing an encounter?
Maybe by rigging the probabilities for the desired encounter?

Neither did I. As for encouters, they do not "happen" as events do. Something has to call it, be it a ritual, an another encounter, or a hero encountering (hence the name) a site. Sites are created when the map is, but there may be a way to add a hidden site to province via ritual, should you need it for testing.
_________________
Phenomenal self as such is not an epistemically justified form of mental content.

Boon947

}↑↑ Великий Лучник
Ветеран

Свитков: 667
С нами с: 24.09.2014

Добавлено: Сб Dec 06, 2014 2:51 Заголовок сообщения: Format string mismatches

Sat,

You've got several format string mismatches, which is double plus ungood, because most of these will crash the game.

Код:

+campaign_dialog.var:8773:%s
-dialog.var:594:%s
-dialog.var:7702:%s
-dialog.var:7945:%s
-dialog.var:8161:%s
-dialog.var:9584:%d
-dialog.var:9591:%d
-dialog.var:11070:%s
-dialog.var:13713:%s
-dialog.var:13767:%s
-dialog.var:13798:%s
-dialog.var:14205:%s
-dialog.var:14366:%s
-dialog.var:15015:%s
-quest.var:664:%s

(The number is the line number obviously)

Regards.

Wayne

Боец

Свитков: 14
С нами с: 19.10.2014

Добавлено: Сб Dec 06, 2014 7:46 Заголовок сообщения:

Boon947 писал(а):

Do you mean this event:

Код:

Yes, that's the one, thanks. I've seen that event 3 times since trying the new translation. The first two times I chose Answer2, and the third time Answer3. All three times I saw no further dialog boxes, and I'm fairly sure that the second time the province income did not change. BTW, this was all with version 2.04 or earlier, somehow I missed the announcement of 2.08. I'll update now and post again the next time I get that event.

Cheers, Wayne