New Horizons v14.0920 ENG v2.0 (Satshanti) Bug Reports

Добавлено: Сб Dec 06, 2014 11:16     Заголовок сообщения: Re: Format string mismatches


I'm sorry, I understand the meaning of the three separate words in "format string mismatch", but put together I have no idea what it means and what's wrong. I had a look at the lines and it all looks okay to me. Could you explain what's wrong in a bit more detail. Thanks!

Добавлено: Сб Dec 06, 2014 12:24     Заголовок сообщения: Re: Format string mismatches


I think this article explains format strings nicely:
https://en.wikipedia.org/wiki/Printf_format_string

Short version: %s and %d are special character sequences which MUST survive the translation (in the exact order).

For example, take the dialog.var:594 issue:


(Unrelated issue: the sentence "дальнейшее разграбление не представляется возможным." = "further looting is not possible." seems to have been lost)

Russian version: %s %d %s
English version: %d %s => WILL CRASH

Weirdly, GOG fixed precisely the same issue between versions 1.05.1 and 1.05.2!

(Note that the GOG translation is not perfect.)

Regards.

Добавлено: Сб Dec 06, 2014 13:04     Заголовок сообщения:


Got it now, will fix those issues asap. Thanks, Boon, I was aware of the need to preserve the strings, but not about ALL of them being needed and in the EXACT order, which can be more tricky with different languages.

Добавлено: Сб Dec 06, 2014 14:54     Заголовок сообщения: Re: Format string mismatches


I fixed most of the above issues with patch 2.09, except for the two at 9584 and 9591. Drakon's team marked these entries as "obsolete", and they therefore don't have the %d in them. This might be fine because they are in fact obsolete, so the game will never call these entries.

But what about the one in quest.var, which I also left as is for now. In that file, the name of /22 reads "Свиток %s", roughly translated as "Scroll %s", but the translation used, also in 1.5 I think, is "Obtaining the Scroll", so without any %s in it. Do you really think the game would crash at that point? Could it be that for the game engine it's actually okay if it cannot find the strings it looks for? This is of course quite an important issue, so could one of the modders (Kettarienne?) confirm or deny that assumption.

Добавлено: Сб Dec 06, 2014 18:14     Заголовок сообщения: Re: Format string mismatches


Just an FYI, the way you are releasing new patches by just editing your post(s) in the Release thread does not trigger the forum software's "watch this thread" algorithm to send out an email. May I suggest a new post for each patch, as well?

Thanks,
Wayne

Добавлено: Сб Dec 06, 2014 18:25     Заголовок сообщения: Re: Format string mismatches


Thanks, Wayne, I didn't realize that. I didn't want to make the release thread unnecessarily long and there's a patch coming out each day now. I'll continue as before with the new patch always in the second post, but whenever I upload a patch, I'll also create a separate new post saying something like "NEW PATCH v2.xx RELEASED", which I will subsequently delete after a minute. That should send out notification emails without clogging the thread.

Добавлено: Сб Dec 06, 2014 20:10     Заголовок сообщения:

When I explored a "Mercenaries Guild", the description text was long enough that the list of defenders was cut off after the first line.

Cheers, Wayne

Добавлено: Вс Dec 07, 2014 2:10     Заголовок сообщения:


Can you confirm that you are referring to dialog 2053?

/105
Name: Mercenaries Guild;
Dialog: 2053

This description is 379 characters long. By comparison, the Russian text is 321 characters long.

I don't understand the juxtaposition of sentences.
sentence 1 = the guild attracts mercenaries (Is куда стекаются наёмники correctly translated?)
sentence 2 = the guild is neutral... in what conflict? And what's the point of mentioning the tavern as recruitment venue?
sentence 3 = OK so the Guild's leaders don't like you coming too close. Fair enough, I suppose; they have a keen sense of private property. Although not allowing the Lord's emissary on their property is somewhat of an insult to the Lord, isn't it?

Not sure what to make of this word/concept salad...

My suggestion: zap the second sentence (unless I completely missed the point)

The hero %s approaches a well-fortified stronghold, which attracts all kinds of mercenaries. Coming too close will be considered an aggression, and the Guild's multitudes will rise to its defense.

198 characters.

ALTERNATE SUGGESTION: replace "an aggression" with "casus belli" (I like that term, but it may not be completely appropriate)

https://en.wikipedia.org/wiki/Casus_belli
https://en.wiktionary.org/wiki/multitude
https://en.wiktionary.org/wiki/multitudinous
https://en.wiktionary.org/wiki/myriad

Regards.

Добавлено: Пн Dec 08, 2014 17:50     Заголовок сообщения:


I also couldn't make heads or tails of this text during translation, so I asked Ket and he translated it for me. What I think the 2nd sentence means is that the guild is for mercenaries only. They are neutral in a sense that they are without master, in between jobs, so to speak, and they like it that way, so IF they would be interested in being hired by a certain Lord, they would go to a tavern in that lord's demesne and sollicit recruitment. This means that representatives of these lords are not welcome on guild territory, because they just "want to be left alone and have a good time" and not be bothered by recruiters trying to get them to sign up for this or that lord. This is all conjecture of course.

I have therefore used your suggestions, but added another, possibly more clear second sentence, also because that keeps the TM aligned:

"The hero %s approaches a well-fortified stronghold, which attracts all kinds of mercenaries.
By unwritten rules, the independent guild of mercenaries is considered neutral territory, and recruiters are not invited.
Coming too close would be considered an aggression, and the Guild's multitudes would rise to its defense."

Добавлено: Пн Dec 08, 2014 22:39     Заголовок сообщения:


321 characters, just like the Russian version
Were you able to check in-game that it fits?

I would write "are not welcome" instead of "are not invited".
https://en.wiktionary.org/wiki/welcome#Adjective

Regards.

Добавлено: Пн Dec 08, 2014 23:08     Заголовок сообщения:

Hello there, greetings from Croatia! First of all, my big thanks to all of you involved in this awesome project, creators, translators, testers. Being lurking on this forum since I first discovered this wonderful mod. When I found out that somebody translated the latest version I finally decided to register.

Ok, to make myself useful right away. I found 2 bugs in translation. When you click on Gnoll or Alvari (drow/dark elf) province to read their description, there is no text. Just some number with the name of the race:

9/ Alvar
10/ Gnoll

Will report if I find any new ones.

Once, again thank you for all your efforts.

Kind regards,
Februarius

Добавлено: Вт Dec 09, 2014 0:54     Заголовок сообщения:


No, haven't seen it in game yet. If anyone does, please let me know if it doesn't fit.
And yes, I agree! Only after I had already implemented the patch, did I read it back and also thought it should be "welcome" rather than "invited". I'll change it next time...

Добавлено: Вт Dec 09, 2014 1:02     Заголовок сообщения:


Welcome, and thank you. These are not two bugs, but only one, a hash sign (#) in races.txt: at /8 Lizardmen that shouldn't be there. There were still quite a few of these bugs in the original 2.0 release, and I thought they'd all been found and fixed by now, but I was wrong apparently. Thanks for pointing this out. I'll fix it first thing tomorrow morning.

Добавлено: Вт Dec 09, 2014 1:15     Заголовок сообщения:


Doesn't fit

Savegame tested: https://www.dropbox.com/s/k51ixynwwwtqs4g/Mercenaries%20Guild.7z?dl=0
Only 6 unit types fit in guild description; site contains 10 different unit types.

Maybe change "By unwritten rules, the independent guild of mercenaries is considered neutral territory ..." to "The guild of mercenaries considers itself neutral territory ..." to make enough room for unit types

Добавлено: Вт Dec 09, 2014 14:01     Заголовок сообщения:


I've changed it to:

"The hero %s approaches a well-fortified stronghold, home to the Mercenary Guild. It is considered neutral territory and recruiters are not welcome here.
Coming too close would be considered an aggression, and the Guild's multitudes would rise to its defense."

Tested with your saved game and it now fits. Thanks!

Добавлено: Вт Dec 09, 2014 18:43     Заголовок сообщения:

Same length problem with Tower of Darkness. Here's a save file:

https://drive.google.com/file/d/0B02Fy_tMfdnHT2xLSnhQT0VwdG8/view?usp=sharing

Cheers, Wayne

Добавлено: Вт Dec 09, 2014 19:30     Заголовок сообщения:


Thanks, Wayne! I've changed it to:

"The hero %s nears the tower. It used to be a Conclave of Mages, where they studied and practiced their magic. This still continues, but the magic studied has changed and not all mages are actually alive. The mages inhabiting the tower, alive or not, will protect themselves against any attack."

I tested it and it now fits. Will be fixed with the next patch.

Добавлено: Ср Dec 10, 2014 15:13     Заголовок сообщения:



I entered site with Holy Knight alone for testing.

Issue: Creatures summoned with spells "Summon Hnara" and "Summon Skeleton" start out at only approx. 70% of health - however, should be 100 %.

Добавлено: Ср Dec 10, 2014 15:17     Заголовок сообщения:


I don't think this is an error that got introduced with the translation. It must already exist in the Russian version too. Kettarienne, could you possibly have a look at this?

Добавлено: Ср Dec 10, 2014 15:29     Заголовок сообщения:

When you play in high-level difficulty, around the last in list, all summoned units haven't full health. It's very old kind of bug or feature (it's easier to kill this unit in more difficulty level than in less, because of lower health). And yes, it's not a translation error, of course.